Stop treating finals as const

Stop treating finals as const

Toplevel final variables and static final fields are no longer
considered compile-time constants.
Committed: https://code.google.com/p/dart/source/detail?r=12289

[regis, 2012-09-12 23:46:57]

LGTM

http://codereview.chromium.org/10918203/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10918203/diff/1/runtime/vm/parser.cc#newcode868
runtime/vm/parser.cc:868: // exception. The field should instead be set to null
after an exception.
This contradicts the comment on line 814 stating that the field is reset to null
before throwing.

[hausner, 2012-09-12 23:51:54]

Thank you.

http://codereview.chromium.org/10918203/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10918203/diff/1/runtime/vm/parser.cc#newcode868
runtime/vm/parser.cc:868: // exception. The field should instead be set to null
after an exception.
No. The comment refers to the code under condition 'if (field.value ===
sentinel)'.

On 2012/09/12 23:46:58, regis wrote:
> This contradicts the comment on line 814 stating that the field is reset to
null
> before throwing.

[regis, 2012-09-12 23:59:04]

http://codereview.chromium.org/10918203/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10918203/diff/1/runtime/vm/parser.cc#newcode868
runtime/vm/parser.cc:868: // exception. The field should instead be set to null
after an exception.
On 2012/09/12 23:51:54, hausner wrote:
> No. The comment refers to the code under condition 'if (field.value ===
> sentinel)'.
> 
> On 2012/09/12 23:46:58, regis wrote:
> > This contradicts the comment on line 814 stating that the field is reset to
> null
> > before throwing.
> 

I stand corrected :-)
Btw, there was an email discussion on this topic on Aug 15 entitled "lazy
initialization of finals".