Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 10917264: Fix dart:html generated directory structure and unify file names between backends. (Closed)

Created:
8 years, 3 months ago by podivilov
Modified:
8 years, 3 months ago
Reviewers:
vsm, Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix dart:html generated directory structure and unify file names between backends. New structure looks like this: generated ├── dart2js │   ├── dart │   │   └── (interfaces, implementations, factory providers) │   └── html_dart2js.dart └── dartium ├── cpp │   └── (native bindings) ├── dart │   └── (interfaces, implementations, factory providers) ├── DartDerivedSources.cpp ├── DartResolver.cpp └── html_dartium.dart R=antonm@google.com,vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=12426

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+806 lines, -836 lines) Patch
M lib/html/dartium/html_dartium.dart View 33 chunks +750 lines, -750 lines 0 comments Download
M lib/html/scripts/dartdomgenerator.py View 4 chunks +34 lines, -28 lines 0 comments Download
M lib/html/scripts/systembase.py View 1 chunk +0 lines, -12 lines 0 comments Download
M lib/html/scripts/systemhtml.py View 6 chunks +22 lines, -34 lines 1 comment Download
M lib/html/scripts/systemnative.py View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 3 months ago (2012-09-14 15:35:00 UTC) #1
Anton Muhin
lgtm https://codereview.chromium.org/10917264/diff/1/lib/html/scripts/systemhtml.py File lib/html/scripts/systemhtml.py (right): https://codereview.chromium.org/10917264/diff/1/lib/html/scripts/systemhtml.py#newcode564 lib/html/scripts/systemhtml.py:564: filename = '%sImpl.dart' % self._html_interface_name as an option: ...
8 years, 3 months ago (2012-09-14 15:48:12 UTC) #2
vsm
I assume the indentation in your review comment is off? I.e., everything after dartium (e.g., ...
8 years, 3 months ago (2012-09-14 16:04:14 UTC) #3
podivilov
8 years, 3 months ago (2012-09-17 09:38:00 UTC) #4
On 2012/09/14 16:04:14, vsm wrote:
> I assume the indentation in your review comment is off?  I.e., everything
after
> dartium (e.g., html_dartium) is in the dartium dir?

Yes, looks like rietveld ignores leading ws for some reason.

> 
> Also, can you run in the regular repo and regenerate html_dart2js as well to
> make sure it works?

html_dart2js hasn't changed because only dartium files are renamed.

> 
> Otherwise, lgtm.

Powered by Google App Engine
This is Rietveld 408576698