Issue 10917254: Move registering of interceptors to the JsBackend.

Issue 10917254: Move registering of interceptors to the JsBackend. (Closed)

Created:
8 years, 3 months ago by karlklose

Modified:
8 years, 2 months ago

Reviewers:
ahe, ngeoffray, kasperl

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move registering of interceptors to the JsBackend. Committed: https://code.google.com/p/dart/source/detail?r=13356

Patch Set 2 : Address Kasper's comment. #

Total comments: 2

Patch Set 3 : Add back check for resolved selectors. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -8 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/backend.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/enqueue.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/js_backend/backend.dart	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1 2	1 chunk	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

kasperl

https://chromiumcodereview.appspot.com/10917254/diff/1/lib/compiler/implementation/js_backend/backend.dart File lib/compiler/implementation/js_backend/backend.dart (right): https://chromiumcodereview.appspot.com/10917254/diff/1/lib/compiler/implementation/js_backend/backend.dart#newcode433 lib/compiler/implementation/js_backend/backend.dart:433: Interceptors interceptors; final? https://chromiumcodereview.appspot.com/10917254/diff/1/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://chromiumcodereview.appspot.com/10917254/diff/1/lib/compiler/implementation/resolver.dart#newcode1549 lib/compiler/implementation/resolver.dart:1549: ...

8 years, 3 months ago (2012-09-14 09:04:41 UTC) #4

karlklose

Kasper, I moved the lookup to world. PTAL. http://codereview.chromium.org/10917254/diff/1/lib/compiler/implementation/js_backend/backend.dart File lib/compiler/implementation/js_backend/backend.dart (right): http://codereview.chromium.org/10917254/diff/1/lib/compiler/implementation/js_backend/backend.dart#newcode433 lib/compiler/implementation/js_backend/backend.dart:433: Interceptors ...

8 years, 2 months ago (2012-10-08 13:15:34 UTC) #5

ngeoffray

http://codereview.chromium.org/10917254/diff/7001/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (left): http://codereview.chromium.org/10917254/diff/7001/lib/compiler/implementation/resolver.dart#oldcode1723 lib/compiler/implementation/resolver.dart:1723: if (target == null) { Where is that check ...

8 years, 2 months ago (2012-10-08 13:50:39 UTC) #8

karlklose

8 years, 2 months ago (2012-10-08 13:59:36 UTC) #9

http://codereview.chromium.org/10917254/diff/7001/lib/compiler/implementation...
File lib/compiler/implementation/resolver.dart (left):

http://codereview.chromium.org/10917254/diff/7001/lib/compiler/implementation...
lib/compiler/implementation/resolver.dart:1723: if (target == null) {
On 2012/10/08 13:50:39, ngeoffray wrote:
> Where is that check now?

I added it back. Thanks for catching that.

Expand Messages | Collapse Messages