Report errors when the number of arguments don't match the number of parameters in a const construc…

Report errors when the number of arguments don't match the number of parameters in a const constructor call.
Committed: https://code.google.com/p/dart/source/detail?r=12435

[kasperl, 2012-09-17 09:01:45]

LGTM, but:

https://codereview.chromium.org/10916335/diff/1/lib/compiler/implementation/c...
File lib/compiler/implementation/compile_time_constants.dart (right):

https://codereview.chromium.org/10916335/diff/1/lib/compiler/implementation/c...
lib/compiler/implementation/compile_time_constants.dart:548: MessageKind kind =
MessageKind.INVALID_NUMBER_OF_ARGUMENTS;
I guess this really isn't just about the number of arguments -- it is also about
the names, right?

https://codereview.chromium.org/10916335/diff/1/lib/compiler/implementation/w...
File lib/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/10916335/diff/1/lib/compiler/implementation/w...
lib/compiler/implementation/warnings.dart:92: "invalid number of arguments
passed to #{1}");
Doesn't seem quite accurate when there's a mismatch in the names.

https://codereview.chromium.org/10916335/diff/1/tests/language/compile_time_c...
File tests/language/compile_time_constant_arguments_test.dart (right):

https://codereview.chromium.org/10916335/diff/1/tests/language/compile_time_c...
tests/language/compile_time_constant_arguments_test.dart:12: print(const A(1,
2)); /// 02: compile-time error, static type warning
This should be extended with something that checks that we get a reasonable
error when you're providing the wrong names for arguments.

[ngeoffray, 2012-09-17 09:10:09]

Thanks Kasper, PTAL

https://codereview.chromium.org/10916335/diff/1/lib/compiler/implementation/c...
File lib/compiler/implementation/compile_time_constants.dart (right):

https://codereview.chromium.org/10916335/diff/1/lib/compiler/implementation/c...
lib/compiler/implementation/compile_time_constants.dart:548: MessageKind kind =
MessageKind.INVALID_NUMBER_OF_ARGUMENTS;
On 2012/09/17 09:01:45, kasperl wrote:
> I guess this really isn't just about the number of arguments -- it is also
about
> the names, right?

Good point. I chnaged the warning kind.

https://codereview.chromium.org/10916335/diff/1/tests/language/compile_time_c...
File tests/language/compile_time_constant_arguments_test.dart (right):

https://codereview.chromium.org/10916335/diff/1/tests/language/compile_time_c...
tests/language/compile_time_constant_arguments_test.dart:12: print(const A(1,
2)); /// 02: compile-time error, static type warning
On 2012/09/17 09:01:45, kasperl wrote:
> This should be extended with something that checks that we get a reasonable
> error when you're providing the wrong names for arguments.

Done.

[kasperl, 2012-09-17 13:44:52]

LGTM.