Support proper parsing of sequence<T>.

Support proper parsing of sequence<T>.

And minor refactoring.

R=podivilov@chromium.org

Committed: https://code.google.com/p/dart/source/detail?r=12337

[podivilov, 2012-09-13 13:01:57]

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/generator.py#...
lib/html/scripts/generator.py:98: def MaybeListElementTypeName(type_name):
If there is just one usage, why not inline?

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/idlnode.py
File lib/html/scripts/idlnode.py (left):

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/idlnode.py#ol...
lib/html/scripts/idlnode.py:323: self.id = self._label_to_type(label, ast)
The new code is very hard to read. Please replace the line above with something
like self.id = findType(...) and keep overall structure as is.

[Anton Muhin, 2012-09-13 13:10:47]

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/generator.py#...
lib/html/scripts/generator.py:98: def MaybeListElementTypeName(type_name):
On 2012/09/13 13:01:57, podivilov wrote:
> If there is just one usage, why not inline?

Done.

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/idlnode.py
File lib/html/scripts/idlnode.py (left):

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/idlnode.py#ol...
lib/html/scripts/idlnode.py:323: self.id = self._label_to_type(label, ast)
On 2012/09/13 13:01:57, podivilov wrote:
> The new code is very hard to read. Please replace the line above with
something
> like self.id = findType(...) and keep overall structure as is.

Sorry, do not quite follow, may you provide some more details?

Technically there can be nested structures like sequence<sequence<int>>

[podivilov, 2012-09-13 14:01:39]

lgtm

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/idlnode.py
File lib/html/scripts/idlnode.py (right):

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/idlnode.py#ne...
lib/html/scripts/idlnode.py:321: for childAst in ast:
nit: for (label, childAst) in ast

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/idlnode.py#ne...
lib/html/scripts/idlnode.py:325: if type == 'sequence':
Please move this code out of the loop and use early returns instead of nested
ifs.

[Anton Muhin, 2012-09-13 14:47:53]

ptal

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/idlnode.py
File lib/html/scripts/idlnode.py (right):

http://codereview.chromium.org/10916286/diff/1/lib/html/scripts/idlnode.py#ne...
lib/html/scripts/idlnode.py:321: for childAst in ast:
On 2012/09/13 14:01:39, podivilov wrote:
> nit: for (label, childAst) in ast

There are some technical issues with it, but as you ask me rewrite this function
anyway, let's see what I can do.

[podivilov, 2012-09-13 15:22:44]

lgtm

http://codereview.chromium.org/10916286/diff/8001/lib/html/scripts/idlnode.py
File lib/html/scripts/idlnode.py (right):

http://codereview.chromium.org/10916286/diff/8001/lib/html/scripts/idlnode.py...
lib/html/scripts/idlnode.py:324: type = self._label_to_type(label, ast)
Please move this statement inside the loop.

[Anton Muhin, 2012-09-13 16:18:38]

Thanks a lot for review, submitting

http://codereview.chromium.org/10916286/diff/8001/lib/html/scripts/idlnode.py
File lib/html/scripts/idlnode.py (right):

http://codereview.chromium.org/10916286/diff/8001/lib/html/scripts/idlnode.py...
lib/html/scripts/idlnode.py:324: type = self._label_to_type(label, ast)
On 2012/09/13 15:22:44, podivilov wrote:
> Please move this statement inside the loop.

Done.