Issue 1091553005: Fix bug in DateTime.parse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1091553005: Fix bug in DateTime.parse. (Closed)

Created:
5 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Fix bug in DateTime.parse. Used unescaepd "." to match "." in RegExp. BUG= http://dartbug.com/22468 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45274

Patch Set 2 : Avoid using double.parse in DateTime.parse. #

Total comments: 1

Patch Set 3 : Add test that failed with the earlier double.parse strategy. #

Patch Set 4 : Shorter line #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -8 lines)			Patch
	M	sdk/lib/core/date_time.dart	View	1 2 3	4 chunks	+37 lines, -8 lines	0 comments	Download
	M	tests/corelib/date_time_parse_test.dart	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Søren Gjesse

lgtm https://codereview.chromium.org/1091553005/diff/20001/sdk/lib/core/date_time.dart File sdk/lib/core/date_time.dart (right): https://codereview.chromium.org/1091553005/diff/20001/sdk/lib/core/date_time.dart#newcode267 sdk/lib/core/date_time.dart:267: r'(?:[ T](\d\d)(?::?(\d\d)(?::?(\d\d)(?:\.(\d{1,6}))?)?)?' // The time part Long line.

5 years, 8 months ago (2015-04-20 10:18:44 UTC) #3

Lasse Reichstein Nielsen

5 years, 8 months ago (2015-04-20 10:27:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 45274 (presubmit successful).