Issue 10915256: FIx crash in disassembler: check that an addrs is tagged before testing it to be part of the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10915256: FIx crash in disassembler: check that an addrs is tagged before testing it to be part of the heap. (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

FIx crash in disassembler: check that an addrs is tagged before testing it to be part of the heap. Committed: https://code.google.com/p/dart/source/detail?r=12308

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
M	runtime/vm/assembler_ia32.cc	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/disassembler_x64.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

lgtm