Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1091483002: Use templates for BulkMixin messages. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use templates for BulkMixin messages. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=45194

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -60 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 24 chunks +63 lines, -59 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 8 months ago (2015-04-15 12:12:25 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1091483002/diff/1/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart File pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart (right): https://codereview.chromium.org/1091483002/diff/1/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart#newcode21 pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart:21: implements SemanticSendVisitor<R, A>, BulkHandle<R, A> { I would ...
5 years, 8 months ago (2015-04-15 13:24:45 UTC) #3
Johnni Winther
https://codereview.chromium.org/1091483002/diff/1/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart File pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart (right): https://codereview.chromium.org/1091483002/diff/1/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart#newcode21 pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart:21: implements SemanticSendVisitor<R, A>, BulkHandle<R, A> { On 2015/04/15 13:24:45, ...
5 years, 8 months ago (2015-04-15 14:35:40 UTC) #4
Johnni Winther
5 years, 8 months ago (2015-04-16 08:02:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 45194 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698