Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1091443003: Move constant systems into their own libraries. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Move constant systems into their own libraries. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45241

Patch Set 1 : #

Patch Set 2 : Rebased #

Patch Set 3 : Fix try/poi/forget_element_test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -137 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer2dart/lib/src/dart_backend.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +14 lines, -1 line 0 comments Download
D pkg/compiler/lib/src/constant_system.dart View 1 chunk +0 lines, -110 lines 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 1 chunk +7 lines, -1 line 0 comments Download
A + pkg/compiler/lib/src/constants/constant_system.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 2 chunks +10 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_constprop_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/value_range2_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/try/poi/forget_element_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
5 years, 8 months ago (2015-04-17 12:19:23 UTC) #3
karlklose
LGTM.
5 years, 8 months ago (2015-04-17 12:24:12 UTC) #4
Johnni Winther
5 years, 8 months ago (2015-04-17 16:31:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) manually as 45241 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698