Issue 1091343002: Fix tests in bots (handle 'is' as an invalid binary operator)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1091343002: Fix tests in bots (handle 'is' as an invalid binary operator) (Closed)

Created:
5 years, 8 months ago by Siggi Cherem (dart-lang)

Modified:
5 years, 8 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Fix tests in bots (handle 'is' as an invalid binary operator) TBR=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45251

Patch Set 1 #

Total comments: 2

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -21 lines)			Patch
	M	pkg/compiler/lib/src/compile_time_constants.dart	View		1 chunk	+24 lines, -21 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/1091343002/diff/1/pkg/compiler/lib/src/compile_time_constants.dart File pkg/compiler/lib/src/compile_time_constants.dart (right): https://codereview.chromium.org/1091343002/diff/1/pkg/compiler/lib/src/compile_time_constants.dart#newcode597 pkg/compiler/lib/src/compile_time_constants.dart:597: switch (operator.kind) { FYI - no changes below besides ...

5 years, 8 months ago (2015-04-17 19:19:24 UTC) #1

Siggi Cherem (dart-lang)

Committed patchset #1 (id:1) manually as 45251 (presubmit successful).

5 years, 8 months ago (2015-04-17 19:20:57 UTC) #2

Johnni Winther

5 years, 8 months ago (2015-04-17 20:31:15 UTC) #3

Message was sent while issue was closed.

LGTM, thanks!

https://codereview.chromium.org/1091343002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/1091343002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compile_time_constants.dart:597: switch (operator.kind) {
On 2015/04/17 19:19:23, Siggi Cherem (dart-lang) wrote:
> FYI - no changes below besides indentation

Thanks. I think `node=="as"` also ends here.

Expand Messages | Collapse Messages