Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1091133002: Add a separate test verifying that the optimizer does not trip over debug break. (Closed)

Created:
5 years, 8 months ago by regis
Modified:
5 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a separate test verifying that the optimizer does not trip over debug break. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45300

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M tests/language/language.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/vm/debug_break_enabled_vm_test.dart View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M tests/language/vm/debug_break_vm_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
Still not optimal, but testing a bit more.
5 years, 8 months ago (2015-04-16 23:00:57 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/1091133002/diff/40001/tests/language/vm/debug_break_enabled_vm_test.dart File tests/language/vm/debug_break_enabled_vm_test.dart (right): https://codereview.chromium.org/1091133002/diff/40001/tests/language/vm/debug_break_enabled_vm_test.dart#newcode13 tests/language/vm/debug_break_enabled_vm_test.dart:13: if (i == 18) break "hit"; / ...
5 years, 8 months ago (2015-04-20 22:05:14 UTC) #3
regis
Thanks! https://codereview.chromium.org/1091133002/diff/40001/tests/language/vm/debug_break_enabled_vm_test.dart File tests/language/vm/debug_break_enabled_vm_test.dart (right): https://codereview.chromium.org/1091133002/diff/40001/tests/language/vm/debug_break_enabled_vm_test.dart#newcode13 tests/language/vm/debug_break_enabled_vm_test.dart:13: if (i == 18) break "hit"; / / ...
5 years, 8 months ago (2015-04-20 23:17:59 UTC) #4
regis
5 years, 8 months ago (2015-04-20 23:20:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as r45300 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698