Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Issue 10911307: Support sequence<T> as return type. (Closed)

Created:
8 years, 3 months ago by Anton Muhin
Modified:
8 years, 3 months ago
Reviewers:
podivilov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M lib/html/scripts/generator.py View 1 3 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anton Muhin
8 years, 3 months ago (2012-09-14 12:45:07 UTC) #1
podivilov
http://codereview.chromium.org/10911307/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): http://codereview.chromium.org/10911307/diff/1/lib/html/scripts/generator.py#newcode674 lib/html/scripts/generator.py:674: def as_item_converter(self): Why do you return primitive types from ...
8 years, 3 months ago (2012-09-14 13:24:46 UTC) #2
Anton Muhin
http://codereview.chromium.org/10911307/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): http://codereview.chromium.org/10911307/diff/1/lib/html/scripts/generator.py#newcode674 lib/html/scripts/generator.py:674: def as_item_converter(self): On 2012/09/14 13:24:46, podivilov wrote: > Why ...
8 years, 3 months ago (2012-09-14 13:26:12 UTC) #3
podivilov
lgtm http://codereview.chromium.org/10911307/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): http://codereview.chromium.org/10911307/diff/1/lib/html/scripts/generator.py#newcode644 lib/html/scripts/generator.py:644: def as_item_converter(self): I hope it's temporary anyway, so ...
8 years, 3 months ago (2012-09-14 15:15:03 UTC) #4
Anton Muhin
8 years, 3 months ago (2012-09-14 15:30:45 UTC) #5
http://codereview.chromium.org/10911307/diff/1/lib/html/scripts/generator.py
File lib/html/scripts/generator.py (right):

http://codereview.chromium.org/10911307/diff/1/lib/html/scripts/generator.py#...
lib/html/scripts/generator.py:644: def as_item_converter(self):
On 2012/09/14 15:15:04, podivilov wrote:
> I hope it's temporary anyway, so let's call it
> vector_to_dart_template_parameter. At least it's honest :)

Thanks a lot!

Powered by Google App Engine
This is Rietveld 408576698