Parse new library syntax.

Parse new library syntax.

Committed: https://code.google.com/p/dart/source/detail?r=12386
But reverted in: https://code.google.com/p/dart/source/detail?r=12387

Committed: https://code.google.com/p/dart/source/detail?r=12686

[Johnni Winther, 2012-09-14 09:18:22]

lgtm

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:101: listener.popNode(); //
TODO(ahe): Hack.
Why not just pop the node in endExport and discard it there?

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:153: } while (optional(',',
token));
If this is true token should also be updated to token = token.next to step over
the comma.

[Lasse Reichstein Nielsen, 2012-09-14 09:36:09]

LGTM

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/listener.dart (right):

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/listener.dart:615: // Script tags are
only allowed in the library file itself, not in
Script -> Library?

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/listener.dart:952:
compilationUnitElement.getLibrary().addTag(tag, listener);
Why is this not using addLibraryTag?

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:56: return
parseExport(token);
Are we not supporting "part"?

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:114: if ('hide' === value)
{
Why not (value === 'hide')?

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:126: /// hide
identifierList
Make comment sentence. (Capitalized start, full stop at end).
Also notice that /// is a doc-comment now.

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:153: } while (optional(',',
token));
Missing token = token.next after recognizing ','.
How about:
  
  token = parseIdentifier(token);
  int count = 1;
  while (optional(',', token)) {
    token = parseIdentifier(token.next);
    count++;
  }

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/scanner_task.dart:55: } else if
(tag.isPart) {
We need to understand both 'part' and 'part of' - will they be different
classes?

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/scanner_task.dart:86: void
importSourceFromTag(LibraryTag tag, Uri path, LibraryElement library) {
LibraryTag -> Part

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/scanner_task.dart:136: LibraryTag tag,
[CompilationUnitElement compilationUnit]) {
LibraryTag -> Import

[ngeoffray, 2012-09-14 09:52:32]

LGTM

[ahe, 2012-09-14 12:13:53]

Thank you, Johnni, Nicolas, and Lasse.

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/listener.dart (right):

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/listener.dart:615: // Script tags are
only allowed in the library file itself, not in
On 2012/09/14 09:36:09, Lasse Reichstein Nielsen wrote:
> Script -> Library?

Done.

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/listener.dart:952:
compilationUnitElement.getLibrary().addTag(tag, listener);
On 2012/09/14 09:36:09, Lasse Reichstein Nielsen wrote:
> Why is this not using addLibraryTag?

This is the implementation of addLibraryTag.

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:56: return
parseExport(token);
On 2012/09/14 09:36:09, Lasse Reichstein Nielsen wrote:
> Are we not supporting "part"?

Not yet.

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:101: listener.popNode(); //
TODO(ahe): Hack.
On 2012/09/14 09:18:22, Johnni Winther wrote:
> Why not just pop the node in endExport and discard it there?

I missed that. I was not supposed to upload the CL with these lines. I don't
think Unipro has seen this language feature yet, so there are no tests (yet).

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:114: if ('hide' === value)
{
On 2012/09/14 09:36:09, Lasse Reichstein Nielsen wrote:
> Why not (value === 'hide')?

Because I felt like it.

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:126: /// hide
identifierList
On 2012/09/14 09:36:09, Lasse Reichstein Nielsen wrote:
> Make comment sentence. (Capitalized start, full stop at end).
> Also notice that /// is a doc-comment now.

This is a doc comment that makes sense in this place. It is not a sentence
because it is a grammar rule.

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/parser.dart:153: } while (optional(',',
token));
On 2012/09/14 09:36:09, Lasse Reichstein Nielsen wrote:
> Missing token = token.next after recognizing ','.
> How about:
>   
>   token = parseIdentifier(token);
>   int count = 1;
>   while (optional(',', token)) {
>     token = parseIdentifier(token.next);
>     count++;
>   }


This is what I had originally. I should have stuck to that :-)

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/scanner_task.dart:55: } else if
(tag.isPart) {
On 2012/09/14 09:36:09, Lasse Reichstein Nielsen wrote:
> We need to understand both 'part' and 'part of' - will they be different
> classes?

I think so. I'll cross that bridge when I get there. I'm very incremental :-)

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/scanner_task.dart:86: void
importSourceFromTag(LibraryTag tag, Uri path, LibraryElement library) {
On 2012/09/14 09:36:09, Lasse Reichstein Nielsen wrote:
> LibraryTag -> Part

Done.

https://chromiumcodereview.appspot.com/10911298/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/scanner/scanner_task.dart:136: LibraryTag tag,
[CompilationUnitElement compilationUnit]) {
On 2012/09/14 09:36:09, Lasse Reichstein Nielsen wrote:
> LibraryTag -> Import

Done.

[ahe, 2012-09-14 14:38:14]

Reverted, I forgot to run the unit tests.

[ahe, 2012-09-18 16:30:36]

Second attempt. I have reused the CL for your convenience (I hope).

The new stuff is in patch set 7, that is "delta from patch set" 6:

https://codereview.chromium.org/10911298/diff2/15001:18001/dart/lib/compiler/...
https://codereview.chromium.org/10911298/diff2/15001:18001/dart/pkg/dartdoc/l...
https://codereview.chromium.org/10911298/diff2/15001:18001/dart/tests/utils/d...

[Johnni Winther, 2012-09-19 07:35:58]

lgtm

[ahe, 2012-09-21 08:48:38]

Additional unrelated fix in:
https://codereview.chromium.org/10911298/diff2/18001:29001/dart/lib/compiler/...

I noticed this when looking at the problems caused by bad optimizations.