Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 10909266: Document the syntax and semantics of Dart regular expressions (the same as JS regexps). (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Document the syntax and semantics of Dart regular expressions (the same as JS regexps). R=lrn@google.com BUG=dartbug.com/89 Committed: https://code.google.com/p/dart/source/detail?r=12431

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M lib/core/regexp.dart View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 3 months ago (2012-09-17 10:48:35 UTC) #1
Lasse Reichstein Nielsen
LGTM https://chromiumcodereview.appspot.com/10909266/diff/1/lib/core/regexp.dart File lib/core/regexp.dart (right): https://chromiumcodereview.appspot.com/10909266/diff/1/lib/core/regexp.dart#newcode73 lib/core/regexp.dart:73: * JavaScript regular expressions. See <http://es5.github.com/#x15.10> JavaScript -> ...
8 years, 3 months ago (2012-09-17 11:03:14 UTC) #2
Mads Ager (google)
8 years, 3 months ago (2012-09-17 11:42:22 UTC) #3
https://chromiumcodereview.appspot.com/10909266/diff/1/lib/core/regexp.dart
File lib/core/regexp.dart (right):

https://chromiumcodereview.appspot.com/10909266/diff/1/lib/core/regexp.dart#n...
lib/core/regexp.dart:73: * JavaScript regular expressions. See
<http://es5.github.com/#x15.10>
On 2012/09/17 11:03:14, Lasse Reichstein Nielsen wrote:
> JavaScript -> ECMAScript.
> The http://es5.github.com page isn't normative, so we should reference 
>  http://ecma-international.org/ecma-262/5.1/#sec-15.10
> instead.

Thanks! Updated.

> One problem is that no browser implements the specification without
extensions,
> so dart2js will definitly accept more than the spec, and if the VM uses
irregexp
> unmodified, it will too :(
> We should probably not say anything about that now.

I agree. Going into those extensions is going to be too much detail for this doc
comment. :)

Powered by Google App Engine
This is Rietveld 408576698