Make super.foo= erroneous if they are not assignable.

Make super.foo= erroneous if they are not assignable.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45250

[Johnni Winther, 2015-04-17 12:17:36]

johnniwinther@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2015-04-17 12:17:37]

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3016: node.isSuperCall ||
node.isThisCall) {
Remove `node.isThisCall`. It is not a statically known runtime error and we
should only report a warning from typechecker, if any:

class A {
  final a = 42;
  m() {
    this.a = 43; // warning in typechecker
  }
}
main() => new A().m(); // runtime error with NSM

class B {
  var a;
}
class A implements B { // warning about unimplemented a=
  final a = 42;
  m() {
    a = 43; // no warning in typechecker
  }
}
main() => new A().m(); // runtime error with NSM

class A {
  final a = 42;
  m() {
    a = 43; // warning in typechecker
  }
}
class B extends A {
  set a(_) {}
}
main() => new B().m(); // no runtime error

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3026: if (node.isSuperCall)
registry.registerSuperNoSuchMethod();
I would special case super calls here, creating an erroneous element with a
specialized method.

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3030: node.isSuperCall ||
node.isThisCall) {
Similarly regarding `node.isThisCall`. The class could have more complex
hiearchy making this a pure runtime error or even no error.

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3040: if (node.isSuperCall)
registry.registerSuperNoSuchMethod();
I would special case super calls here, creating an erroneous element with a
specialized method.

[Siggi Cherem (dart-lang), 2015-04-17 16:37:29]

Patchset #2 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2015-04-17 16:38:24]

PTAL

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3016: node.isSuperCall ||
node.isThisCall) {
On 2015/04/17 12:17:37, Johnni Winther wrote:
> Remove `node.isThisCall`. It is not a statically known runtime error and we
> should only report a warning from typechecker, if any:
> 
> class A {
>   final a = 42;
>   m() {
>     this.a = 43; // warning in typechecker
>   }
> }
> main() => new A().m(); // runtime error with NSM
> 
> class B {
>   var a;
> }
> class A implements B { // warning about unimplemented a=
>   final a = 42;
>   m() {
>     a = 43; // no warning in typechecker
>   }
> }
> main() => new A().m(); // runtime error with NSM
> 
> class A {
>   final a = 42;
>   m() {
>     a = 43; // warning in typechecker
>   }
> }
> class B extends A {
>   set a(_) {}
> }
> main() => new B().m(); // no runtime error

Good call. Done.

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3026: if (node.isSuperCall)
registry.registerSuperNoSuchMethod();
On 2015/04/17 12:17:37, Johnni Winther wrote:
> I would special case super calls here, creating an erroneous element with a
> specialized method.

Not sure I completely followed - when you say a specialized method, you meant a
specialized message? If so, done :)

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3030: node.isSuperCall ||
node.isThisCall) {
On 2015/04/17 12:17:37, Johnni Winther wrote:
> Similarly regarding `node.isThisCall`. The class could have more complex
> hiearchy making this a pure runtime error or even no error.

Done.

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3040: if (node.isSuperCall)
registry.registerSuperNoSuchMethod();
On 2015/04/17 12:17:37, Johnni Winther wrote:
> I would special case super calls here, creating an erroneous element with a
> specialized method.

Done.

[Johnni Winther, 2015-04-17 17:56:09]

lgtm

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1090923004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3026: if (node.isSuperCall)
registry.registerSuperNoSuchMethod();
On 2015/04/17 16:38:24, Siggi Cherem (dart-lang) wrote:
> On 2015/04/17 12:17:37, Johnni Winther wrote:
> > I would special case super calls here, creating an erroneous element with a
> > specialized method.
> 
> Not sure I completely followed - when you say a specialized method, you meant
a
> specialized message? If so, done :)

'method' -> 'message' !

[Siggi Cherem (dart-lang), 2015-04-17 18:34:36]

Committed patchset #2 (id:40001) manually as 45250 (presubmit successful).