Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 10909200: Fix issues 5137: instance of test on constant value should return true or false, not the value itse… (Closed)

Created:
8 years, 3 months ago by srdjan
Modified:
8 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix issues 5137: instance of test on constant value should return true or false, not the value itself. Committed: https://code.google.com/p/dart/source/detail?r=12319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M tests/standalone/medium_integer_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
8 years, 3 months ago (2012-09-13 11:37:59 UTC) #1
Florian Schneider
8 years, 3 months ago (2012-09-13 11:41:02 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698