Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 1090873002: cps-ir: Replace getter-invocation methods in IR builder. (Closed)

Created:
5 years, 8 months ago by asgerf
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

cps-ir: Replace getter-invocation methods in IR builder. The IR builder is poorly equipped to decide the order in which to evaluate things. ISSUE=https://code.google.com/p/dart/issues/detail?id=23229 R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=45209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -62 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 2 chunks +0 lines, -58 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 4 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 8 months ago (2015-04-16 10:05:03 UTC) #2
Kevin Millikin (Google)
lgtm
5 years, 8 months ago (2015-04-16 11:30:29 UTC) #3
asgerf
5 years, 8 months ago (2015-04-16 14:03:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45209 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698