Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 10908284: Correct handling of return types for callbacks. (Closed)

Created:
8 years, 3 months ago by Anton Muhin
Modified:
8 years, 3 months ago
Reviewers:
podivilov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Correct handling of return types for callbacks. Actually, all WebKit cares about is if callback threw an exception or not. So return type of callbacks should be actually ignored. As of now it is always bool for WebKit IDLs, but sometimes it gets overridden to void by supplemental IDLs. R=podivilov@chromium.org BUG=3016 Committed: https://code.google.com/p/dart/source/detail?r=12440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M lib/html/scripts/systemnative.py View 3 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Anton Muhin
8 years, 3 months ago (2012-09-17 15:06:01 UTC) #1
podivilov
8 years, 3 months ago (2012-09-17 15:59:03 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698