Issue 10908238: Only allow 'void' as a return type.

Issue 10908238: Only allow 'void' as a return type. (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org, jwren

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Only allow 'void' as a return type. Committed: https://code.google.com/p/dart/source/detail?r=12318

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -10 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1 2	3 chunks	+11 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/warnings.dart	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

ahe

Comments so far. https://codereview.chromium.org/10908238/diff/1/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/10908238/diff/1/lib/compiler/implementation/compiler.dart#newcode736 lib/compiler/implementation/compiler.dart:736: DartType resolveTypeAnnotation(Element element, I would rather ...

8 years, 3 months ago (2012-09-13 11:37:16 UTC) #2

karlklose

LGTM. https://codereview.chromium.org/10908238/diff/1/lib/compiler/implementation/warnings.dart File lib/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/10908238/diff/1/lib/compiler/implementation/warnings.dart#newcode251 lib/compiler/implementation/warnings.dart:251: 'Type void is only allowed in a return ...

8 years, 3 months ago (2012-09-13 11:43:11 UTC) #3

ngeoffray

Thanks Karl and Peter https://codereview.chromium.org/10908238/diff/1/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/10908238/diff/1/lib/compiler/implementation/compiler.dart#newcode736 lib/compiler/implementation/compiler.dart:736: DartType resolveTypeAnnotation(Element element, On 2012/09/13 ...

8 years, 3 months ago (2012-09-13 11:45:59 UTC) #6

ahe

https://codereview.chromium.org/10908238/diff/6/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://codereview.chromium.org/10908238/diff/6/lib/compiler/implementation/resolver.dart#newcode226 lib/compiler/implementation/resolver.dart:226: DartType resolveTypeAnnotation(Element element, TypeAnnotation annotation) { I think this ...

8 years, 3 months ago (2012-09-13 11:49:37 UTC) #7

ngeoffray

8 years, 3 months ago (2012-09-13 11:56:56 UTC) #8

https://codereview.chromium.org/10908238/diff/6/lib/compiler/implementation/r...
File lib/compiler/implementation/resolver.dart (right):

https://codereview.chromium.org/10908238/diff/6/lib/compiler/implementation/r...
lib/compiler/implementation/resolver.dart:226: DartType
resolveTypeAnnotation(Element element, TypeAnnotation annotation) {
On 2012/09/13 11:49:37, ahe wrote:
> I think this method could call resolveReturnType.

Done.

Expand Messages | Collapse Messages