Issue 10905265: Support sequence<T> as native bindings arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905265: Support sequence<T> as native bindings arguments. (Closed)

Created:
8 years, 3 months ago by Anton Muhin

Modified:
8 years, 3 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support sequence<T> as native bindings arguments. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=12381

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
	M	lib/html/scripts/generator.py	View		3 chunks	+16 lines, -0 lines	0 comments	Download
	M	lib/html/scripts/systemnative.py	View	1	1 chunk	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm http://codereview.chromium.org/10905265/diff/1/lib/html/scripts/systemnative.py File lib/html/scripts/systemnative.py (right): http://codereview.chromium.org/10905265/diff/1/lib/html/scripts/systemnative.py#newcode839 lib/html/scripts/systemnative.py:839: ' $TYPE $ARGUMENT_NAME;\n'\ nit: unnecessary trailing \ http://codereview.chromium.org/10905265/diff/1/lib/html/scripts/systemnative.py#newcode840 ...

8 years, 3 months ago (2012-09-14 08:06:06 UTC) #2

Anton Muhin

8 years, 3 months ago (2012-09-14 12:32:58 UTC) #3

Thanks a lot for review, submitting

http://codereview.chromium.org/10905265/diff/1/lib/html/scripts/systemnative.py
File lib/html/scripts/systemnative.py (right):

http://codereview.chromium.org/10905265/diff/1/lib/html/scripts/systemnative....
lib/html/scripts/systemnative.py:839: '        $TYPE $ARGUMENT_NAME;\n'\
On 2012/09/14 08:06:06, podivilov wrote:
> nit: unnecessary trailing \

No, it's necessary.  Another option would be to put it into (), but I'd rather
keep as is.

http://codereview.chromium.org/10905265/diff/1/lib/html/scripts/systemnative....
lib/html/scripts/systemnative.py:840: '        $CLS::$FUNCTION($ARGUMENT_NAME,
Dart_GetNativeArgument(args, $INDEX), exception);\n'
On 2012/09/14 08:06:06, podivilov wrote:
> nit: Dart_GetNativeArgument should come first.

Done.

Expand Messages | Collapse Messages

Issue 10905265: Support sequence<T> as native bindings arguments. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages