Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090513002: Support configuring timeouts per-test and -group. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support configuring timeouts per-test and -group. Support for using Timeout as an annotation will come next. See #9 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/8f3150c703369e9dd4fbff93f6d2abe9b36837b6

Patch Set 1 #

Patch Set 2 : Unused import. #

Total comments: 4

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -43 lines) Patch
M lib/src/backend/declarer.dart View 3 chunks +18 lines, -5 lines 0 comments Download
M lib/src/backend/invoker.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/backend/metadata.dart View 2 chunks +28 lines, -8 lines 0 comments Download
A lib/src/frontend/timeout.dart View 1 chunk +47 lines, -0 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M lib/test.dart View 4 chunks +15 lines, -4 lines 0 comments Download
M test/backend/declarer_test.dart View 2 chunks +33 lines, -0 lines 0 comments Download
M test/backend/invoker_test.dart View 2 chunks +71 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 8 months ago (2015-04-15 00:16:14 UTC) #1
kevmoo
https://codereview.chromium.org/1090513002/diff/10010/lib/src/backend/declarer.dart File lib/src/backend/declarer.dart (right): https://codereview.chromium.org/1090513002/diff/10010/lib/src/backend/declarer.dart#newcode9 lib/src/backend/declarer.dart:9: import '../frontend/timeout.dart'; If it's needed in backend, should it ...
5 years, 8 months ago (2015-04-15 02:51:34 UTC) #2
nweiz
Code review changes
5 years, 8 months ago (2015-04-15 20:03:41 UTC) #3
nweiz
https://codereview.chromium.org/1090513002/diff/10010/lib/src/backend/declarer.dart File lib/src/backend/declarer.dart (right): https://codereview.chromium.org/1090513002/diff/10010/lib/src/backend/declarer.dart#newcode9 lib/src/backend/declarer.dart:9: import '../frontend/timeout.dart'; On 2015/04/15 02:51:34, kevmoo wrote: > If ...
5 years, 8 months ago (2015-04-15 20:03:48 UTC) #4
kevmoo
lgtm
5 years, 8 months ago (2015-04-15 21:17:26 UTC) #5
nweiz
5 years, 8 months ago (2015-04-15 21:34:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:30001) manually as
8f3150c703369e9dd4fbff93f6d2abe9b36837b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698