Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090373006: Properly resolve top-level setters (Closed)

Created:
5 years, 8 months ago by hausner
Modified:
5 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Properly resolve top-level setters Fixes issue 4386. When converting a getter to a setter (converting a right-hand side expression to a left-hand side, assignable entity), we need to know where to look for the setter function. Top-level setters need to be resolved in the library or prefix scope in which the getter was found. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=45316

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -65 lines) Patch
M runtime/vm/ast.h View 1 2 7 chunks +39 lines, -2 lines 0 comments Download
M runtime/vm/ast.cc View 1 2 2 chunks +92 lines, -10 lines 2 comments Download
M runtime/vm/ast_transformer.cc View 1 2 2 chunks +15 lines, -6 lines 2 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 chunks +18 lines, -2 lines 0 comments Download
M runtime/vm/parser.h View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 12 chunks +44 lines, -35 lines 0 comments Download
M tests/language/getter_setter_in_lib.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/getter_setter_in_lib2.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
A tests/language/getter_setter_in_lib3.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
M tests/language/getter_setter_in_lib_test.dart View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hausner
5 years, 8 months ago (2015-04-21 00:03:46 UTC) #2
regis
lgtm https://codereview.chromium.org/1090373006/diff/40001/runtime/vm/ast.cc File runtime/vm/ast.cc (right): https://codereview.chromium.org/1090373006/diff/40001/runtime/vm/ast.cc#newcode606 runtime/vm/ast.cc:606: return new StoreStaticFieldNode(token_pos(), field, rhs); Indent lines 600-606. ...
5 years, 8 months ago (2015-04-21 17:30:30 UTC) #3
hausner
Committed patchset #3 (id:40001) manually as r45316 (presubmit successful).
5 years, 8 months ago (2015-04-21 17:36:50 UTC) #4
hausner
5 years, 8 months ago (2015-04-21 17:40:12 UTC) #5
Message was sent while issue was closed. 
Thank you.

https://codereview.chromium.org/1090373006/diff/40001/runtime/vm/ast.cc
File runtime/vm/ast.cc (right):

https://codereview.chromium.org/1090373006/diff/40001/runtime/vm/ast.cc#newco...
runtime/vm/ast.cc:606: return new StoreStaticFieldNode(token_pos(), field, rhs);
On 2015/04/21 17:30:30, regis wrote:
> Indent lines 600-606.

Done.

https://codereview.chromium.org/1090373006/diff/40001/runtime/vm/ast_transfor...
File runtime/vm/ast_transformer.cc (right):

https://codereview.chromium.org/1090373006/diff/40001/runtime/vm/ast_transfor...
runtime/vm/ast_transformer.cc:520: new_value)
On 2015/04/21 17:30:30, regis wrote:
> Indent lines above.

Done.

Powered by Google App Engine
This is Rietveld 408576698