Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090243002: Fix dumpInfo: include information for methods that are not in the generated (Closed)

Created:
5 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 8 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix dumpInfo: include information for methods that are not in the generated output (because of inlining, orelse) R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=45247

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 3 chunks +13 lines, -11 lines 3 comments Download

Messages

Total messages: 5 (1 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1090243002/diff/1/pkg/compiler/lib/src/dump_info.dart File pkg/compiler/lib/src/dump_info.dart (right): https://codereview.chromium.org/1090243002/diff/1/pkg/compiler/lib/src/dump_info.dart#newcode556 pkg/compiler/lib/src/dump_info.dart:556: JsonEncoder encoder = const JsonEncoder.withIndent(' '); this is not ...
5 years, 8 months ago (2015-04-17 15:52:55 UTC) #2
sra1
lgtm https://codereview.chromium.org/1090243002/diff/1/pkg/compiler/lib/src/dump_info.dart File pkg/compiler/lib/src/dump_info.dart (right): https://codereview.chromium.org/1090243002/diff/1/pkg/compiler/lib/src/dump_info.dart#newcode308 pkg/compiler/lib/src/dump_info.dart:308: enclosingElement.isFunction || fix this indentation while you are ...
5 years, 8 months ago (2015-04-17 17:35:46 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 45247 (presubmit successful).
5 years, 8 months ago (2015-04-17 17:52:10 UTC) #4
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-04-17 17:52:21 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1090243002/diff/1/pkg/compiler/lib/src/dump_i...
File pkg/compiler/lib/src/dump_info.dart (right):

https://codereview.chromium.org/1090243002/diff/1/pkg/compiler/lib/src/dump_i...
pkg/compiler/lib/src/dump_info.dart:308: enclosingElement.isFunction ||
On 2015/04/17 17:35:45, sra1 wrote:
> fix this indentation while you are here. Tabs?

Done.

Powered by Google App Engine
This is Rietveld 408576698