Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1090053003: - Avoid inconsistency of for example IterateObjects vs VisitObjects. (Closed)

Created:
5 years, 8 months ago by Ivan Posva
Modified:
5 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, koda
Visibility:
Public.

Description

- Avoid inconsistency of for example IterateObjects vs VisitObjects. The majority of the sites uses VisitXYZ. - Removed IterateNew* and IterateOld* as they are not needed any longer. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=45221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -41 lines) Patch
M runtime/vm/gc_marker.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/heap.h View 1 chunk +2 lines, -10 lines 0 comments Download
M runtime/vm/heap.cc View 3 chunks +5 lines, -25 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object_graph.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/scavenger.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Ivan Posva
5 years, 8 months ago (2015-04-16 22:59:31 UTC) #2
rmacnak
LGTM
5 years, 8 months ago (2015-04-16 23:13:01 UTC) #3
Ivan Posva
5 years, 8 months ago (2015-04-16 23:16:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45221 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698