Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1089793002: Add a command line option to use the new CPS based backend. (Closed)

Created:
5 years, 8 months ago by karlklose
Modified:
5 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, sigurdm, Kevin Millikin (Google), asgerf
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add a command line option to use the new CPS based backend. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45203

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 3 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +1 line, -3 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_closures_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_literals_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_runtime_types_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_source_information_test.dart View 3 chunks +2 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_supercall_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
karlklose
5 years, 8 months ago (2015-04-16 09:05:23 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/1089793002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1089793002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode721 pkg/compiler/lib/src/compiler.dart:721: /// Use the cew CPS based backend end. ...
5 years, 8 months ago (2015-04-16 09:17:06 UTC) #3
karlklose
https://codereview.chromium.org/1089793002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1089793002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode721 pkg/compiler/lib/src/compiler.dart:721: /// Use the cew CPS based backend end. This ...
5 years, 8 months ago (2015-04-16 11:21:47 UTC) #4
karlklose
5 years, 8 months ago (2015-04-16 11:22:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 45203 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698