Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1089453002: Avoid redundant calls to "pub list" when multiple dependencies change. (Closed)

Created:
5 years, 8 months ago by Paul Berry
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, jwren
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Avoid redundant calls to "pub list" when multiple dependencies change. BUG=dartbug.com/22574 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45170

Patch Set 1 #

Patch Set 2 : Add unit tests. #

Patch Set 3 : Add missing source file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -42 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 7 chunks +27 lines, -24 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/source/optimizing_pub_package_map_provider.dart View 1 1 chunk +134 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 3 chunks +38 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 3 chunks +35 lines, -4 lines 0 comments Download
A pkg/analysis_server/test/source/optimizing_pub_package_map_provider_test.dart View 1 2 1 chunk +231 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/source/test_all.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 8 months ago (2015-04-14 23:52:10 UTC) #2
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-15 14:33:03 UTC) #3
Paul Berry
5 years, 8 months ago (2015-04-15 16:02:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 45170 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698