Issue 108943003: Suppressing media events from list of global events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108943003: Suppressing media events from list of global events. (Closed)

Created:
6 years, 11 months ago by blois

Modified:
6 years, 11 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Suppressing media events from list of global events. Fixes analyzer issue TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=31563

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -361 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	10 chunks	+0 lines, -180 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	10 chunks	+0 lines, -180 lines	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View	1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r31563 (presubmit successful).

6 years, 11 months ago (2014-01-07 18:40:36 UTC) #1

vsm

6 years, 11 months ago (2014-01-07 18:45:22 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/108943003/diff/1/tools/dom/scripts/htmleventg...
File tools/dom/scripts/htmleventgenerator.py (right):

https://codereview.chromium.org/108943003/diff/1/tools/dom/scripts/htmleventg...
tools/dom/scripts/htmleventgenerator.py:388: interface.doc_js_name ==
'GlobalEventHandlers'):
There is also WindowEventHandlers now - do we need to drop it there as well?

Expand Messages | Collapse Messages