Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1089183004: Add Uri.directory constructor. (Closed)

Created:
5 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add Uri.directory constructor. Make Directory.uri getter use the new constructor. This also fixes that the uri getter doesn't work correctly on Windows. Add uri getter on file system entity. BUG= http://dartbug.com/17065 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45227

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -13 lines) Patch
M sdk/lib/core/uri.dart View 1 5 chunks +42 lines, -5 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 1 chunk +1 line, -5 lines 0 comments Download
M tests/corelib/uri_file_test.dart View 6 chunks +44 lines, -2 lines 0 comments Download
M tests/standalone/io/file_system_uri_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-17 08:25:58 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/1089183004/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/1089183004/diff/1/sdk/lib/core/uri.dart#newcode779 sdk/lib/core/uri.dart:779: static _makeFileUri(String path, bool slashTerminated) { Optional named ...
5 years, 8 months ago (2015-04-17 08:33:21 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/1089183004/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/1089183004/diff/1/sdk/lib/core/uri.dart#newcode779 sdk/lib/core/uri.dart:779: static _makeFileUri(String path, bool slashTerminated) { No optional arguments ...
5 years, 8 months ago (2015-04-17 08:41:41 UTC) #4
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 45227 (presubmit successful).
5 years, 8 months ago (2015-04-17 08:56:13 UTC) #5
kevmoo
5 years, 6 months ago (2015-06-23 20:53:40 UTC) #6
Message was sent while issue was closed.
On 2015/04/17 08:56:13, Lasse Reichstein Nielsen wrote:
> Committed patchset #2 (id:20001) manually as 45227 (presubmit successful).

Please update CHANGELOG.md when making API changes

Powered by Google App Engine
This is Rietveld 408576698