Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1088933004: Use CallStructure instead of Selector in SemanticSendVisitor. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Anders Johnsen
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use CallStructure instead of Selector in SemanticSendVisitor. BUG= Committed: https://code.google.com/p/dart/source/detail?r=45150

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -471 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 4 chunks +7 lines, -12 lines 0 comments Download
M pkg/analyzer2dart/lib/src/util.dart View 2 chunks +10 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 10 chunks +62 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 27 chunks +73 lines, -100 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 26 chunks +26 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 79 chunks +99 lines, -199 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 7 chunks +33 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 11 chunks +11 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 43 chunks +54 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
https://codereview.chromium.org/1088933004/diff/1/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart File pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart (left): https://codereview.chromium.org/1088933004/diff/1/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart#oldcode5158 pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart:5158: These are (already) in TraversalSendMixin.
5 years, 8 months ago (2015-04-14 16:44:20 UTC) #2
karlklose
STV!
5 years, 8 months ago (2015-04-15 07:23:26 UTC) #3
Johnni Winther
5 years, 8 months ago (2015-04-15 07:43:51 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 45150 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698