Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 108853003: Pass logs through transformer groups. (Closed)

Created:
7 years ago by Bob Nystrom
Modified:
7 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Pass logs through transformer groups. BUG=https://code.google.com/p/dart/issues/detail?id=15189 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=30963

Patch Set 1 #

Patch Set 2 : Fix test suite name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -85 lines) Patch
M pkg/barback/lib/src/phase.dart View 2 chunks +5 lines, -2 lines 0 comments Download
A pkg/barback/test/logger_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
A + pkg/barback/test/multiset_test.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/barback/test/mutliset_test.dart View 1 1 chunk +0 lines, -81 lines 0 comments Download
A pkg/barback/test/transformer/log.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M pkg/barback/test/utils.dart View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
7 years ago (2013-12-06 19:25:03 UTC) #1
nweiz
lgtm
7 years ago (2013-12-06 19:31:12 UTC) #2
Bob Nystrom
7 years ago (2013-12-06 20:23:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r30963 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698