Issue 1088453004: Move browser tests that require installation into their own files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1088453004: Move browser tests that require installation into their own files. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Move browser tests that require installation into their own files. Now, no test suite other than phantomjs_test.dart and dartium_test.dart assume that phantomjs or dartium (respectively) are installed. content_shell is still assumed to be installed, since it's very useful for non-compilation-specific tests. More of those tests have been moved to use content shell rather than chrome. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/5a1ded7c90895dd1f2908f320b7122e7f6ba98da

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+242 lines, -152 lines)			Patch
M	.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/frontend/expect_async_test.dart	View	15 chunks	+15 lines, -15 lines	0 comments	Download
M	test/frontend/matcher/completion_test.dart	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	test/frontend/matcher/prints_test.dart	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	test/frontend/matcher/throws_test.dart	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	test/frontend/matcher/throws_type_test.dart	View	11 chunks	+11 lines, -11 lines	0 comments	Download
M	test/runner/browser/compact_reporter_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/runner/browser/dartium_test.dart	View	3 chunks	+43 lines, -0 lines	0 comments	Download
M	test/runner/browser/firefox_test.dart	View	3 chunks	+52 lines, -0 lines	0 comments	Download
M	test/runner/browser/phantom_js_test.dart	View	3 chunks	+42 lines, -0 lines	0 comments	Download
M	test/runner/browser/runner_test.dart	View	25 chunks	+29 lines, -77 lines	0 comments	Download
M	test/runner/signal_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/runner/test_on_test.dart	View	7 chunks	+24 lines, -22 lines	0 comments	Download
M	test/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

5 years, 8 months ago (2015-04-22 19:34:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5a1ded7c90895dd1f2908f320b7122e7f6ba98da (presubmit successful).

Expand Messages | Collapse Messages