Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1087943002: pkg/analyzer: DRY'd up the parse methods. Aligned arguments between parse File and String (Closed)

Created:
5 years, 8 months ago by kevmoo
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

DRY'd up the parse methods. Aligned arguments between parse File and String R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M pkg/analyzer/lib/analyzer.dart View 2 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kevmoo
5 years, 8 months ago (2015-04-14 21:03:24 UTC) #2
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-14 21:13:05 UTC) #3
kevmoo
5 years, 8 months ago (2015-04-14 21:13:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698