Add annotation for function declarations. Mark functions with performance problems in red.

Add annotation for function declarations. Mark functions with performance problems in red.

Reduce the saturation of the coverage markers.

Creating service-refs is horribly expensive: build the details for call sites and function declarations lazily.

Report is_inlinable instead of CanBeInlined because the latter depends whether the function currently has code or breakpoints.

Committed: https://code.google.com/p/dart/source/detail?r=45217

[rmacnak, 2015-04-15 01:51:03]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[rmacnak, 2015-04-15 17:55:36]

Added scanning to try to place function declaration annotations at their name.
Seems to work pretty well.

[Cutch, 2015-04-16 14:55:27]

LGTMwC

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/script_inset.dart (right):

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:22: if (infoBox == null)
{
add comment that you are lazily generating infobox contents on first click.
consider factoring out construction code into separate local function.

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:42: abstract class
Annotation implements Comparable<Annotation>{
whitespace between > and {

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:150: if (line == null ||
columnStart == null) {
if ((line == null) || (columnStart == null)) {

(here and possibly elsewhere).

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:163: if (betterStart !=
-1) columnStart = betterStart;
if (...) {\n...\n}\n

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:320: for (var func in
lib.functions) func.load();
braces and new lines

[rmacnak, 2015-04-16 18:43:08]

Also figured out the bug that only appeared in dart2js was actually a race: the
service was answering CanBeInlined instead of is_inlinable, which depends on
whether function currently has code. I.e., CanBeInlined is really
CanCurrentlyBeInlined for the optimizer, but for flagging performance problems
we're more interested in whether the function has been marked to never be
inlined in the future.

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/script_inset.dart (right):

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:42: abstract class
Annotation implements Comparable<Annotation>{
On 2015/04/16 14:55:27, Cutch wrote:
> whitespace between > and {

Done.

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:150: if (line == null ||
columnStart == null) {
On 2015/04/16 14:55:27, Cutch wrote:
> if ((line == null) || (columnStart == null)) {
> 
> (here and possibly elsewhere).

Done.

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:163: if (betterStart !=
-1) columnStart = betterStart;
On 2015/04/16 14:55:27, Cutch wrote:
> if (...) {\n...\n}\n

Done.

https://codereview.chromium.org/1087833005/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_inset.dart:320: for (var func in
lib.functions) func.load();
On 2015/04/16 14:55:27, Cutch wrote:
> braces and new lines

Done.

[rmacnak, 2015-04-16 19:06:43]

Committed patchset #6 (id:100001) manually as 45217 (presubmit successful).