Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1087783002: cps-ir: Merge variables based on the source variable's name. (Closed)

Created:
5 years, 8 months ago by asgerf
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

cps-ir: Merge variables based on the source variable's name. Previously we would merge based on the element, but that is a poor strategy when multiple locals have the same name. E.g: for (int i = 0; i < X; ++i) {...} for (int i = 0; i < Y; ++i) {...} The two `i` variables should obviously be merged, but they have different elements. BUG= R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=45134

Patch Set 1 #

Patch Set 2 : Do not substitute parameters #

Patch Set 3 : Bugfix: local variable could not actually merge with parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M pkg/compiler/lib/src/tree_ir/optimization/variable_merger.dart View 1 2 4 chunks +24 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
asgerf
5 years, 8 months ago (2015-04-14 08:47:01 UTC) #2
Kevin Millikin (Google)
lgtm
5 years, 8 months ago (2015-04-14 08:57:53 UTC) #3
asgerf
This caused a bug in dart2dart where a parameter would be substituted by a local ...
5 years, 8 months ago (2015-04-14 10:51:50 UTC) #4
Kevin Millikin (Google)
LGTM.
5 years, 8 months ago (2015-04-14 11:21:39 UTC) #5
asgerf
5 years, 8 months ago (2015-04-14 12:14:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 45134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698