Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1087693002: Don't double-complete in host.dart. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M lib/src/runner/browser/static/host.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/browser/static/host.dart.js View 4 chunks +8 lines, -3 lines 0 comments Download
M lib/src/runner/browser/static/host.dart.js.map View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 8 months ago (2015-04-13 23:25:58 UTC) #1
kevmoo
LGTM - but where's the test?
5 years, 8 months ago (2015-04-13 23:27:14 UTC) #2
nweiz
On 2015/04/13 23:27:14, kevmoo wrote: > LGTM - but where's the test? This wasn't user-visible.
5 years, 8 months ago (2015-04-13 23:28:50 UTC) #3
nweiz
5 years, 8 months ago (2015-04-13 23:29:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bcc0db023ff08437dfba93ab8803e44ba7e21313 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698