Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 108753003: Test source mirrors with lib/mirrors test. (Closed)

Created:
7 years ago by Johnni Winther
Modified:
6 years, 10 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Test source mirrors with lib/mirrors test. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=32280

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Patch Set 3 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -150 lines) Patch
A tests/compiler/dart2js/mirrors/class_mirror_type_variables_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/mirrors_test_helper.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A tests/lib/mirrors/class_mirror_type_variables_data.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/class_mirror_type_variables_expect.dart View 1 2 5 chunks +43 lines, -37 lines 0 comments Download
M tests/lib/mirrors/class_mirror_type_variables_test.dart View 1 chunk +15 lines, -113 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
7 years ago (2013-12-20 12:12:15 UTC) #1
ahe
LGTM! https://codereview.chromium.org/108753003/diff/1/tests/lib/mirrors/class_mirror_type_variables_expect.dart File tests/lib/mirrors/class_mirror_type_variables_expect.dart (right): https://codereview.chromium.org/108753003/diff/1/tests/lib/mirrors/class_mirror_type_variables_expect.dart#newcode14 tests/lib/mirrors/class_mirror_type_variables_expect.dart:14: abstract class Env { Document this allows sharing ...
7 years ago (2013-12-20 14:04:17 UTC) #2
Johnni Winther
https://codereview.chromium.org/108753003/diff/1/tests/lib/mirrors/class_mirror_type_variables_expect.dart File tests/lib/mirrors/class_mirror_type_variables_expect.dart (right): https://codereview.chromium.org/108753003/diff/1/tests/lib/mirrors/class_mirror_type_variables_expect.dart#newcode14 tests/lib/mirrors/class_mirror_type_variables_expect.dart:14: abstract class Env { On 2013/12/20 14:04:17, ahe wrote: ...
6 years, 10 months ago (2014-02-04 13:36:21 UTC) #3
Johnni Winther
6 years, 10 months ago (2014-02-04 13:37:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r32280 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698