cps-ir: Don't bail on assert in unchecked mode.

cps-ir: Don't bail on assert in unchecked mode.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45103

[asgerf, 2015-04-13 12:21:59]

asgerf@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-04-13 12:31:51]

LGTM with a comment.

https://codereview.chromium.org/1087483003/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1087483003/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:639: visitAssert(ast.Send
node, ast.Node condition, _) {
I would prefer to keep the type annotation and to structure the code like this:

  if (compiler.enableUserAssertions) {
    return giveup(node, 'assert in checked mode not implemented');
  } else {
    // The call to assert and its argument expression can be ignored
    // in production mode.
    return null;
  }

[asgerf, 2015-04-13 12:35:55]

https://codereview.chromium.org/1087483003/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1087483003/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:639: visitAssert(ast.Send
node, ast.Node condition, _) {
On 2015/04/13 12:31:51, karlklose wrote:
> I would prefer to keep the type annotation and to structure the code like
this:
> 
>   if (compiler.enableUserAssertions) {
>     return giveup(node, 'assert in checked mode not implemented');
>   } else {
>     // The call to assert and its argument expression can be ignored
>     // in production mode.
>     return null;
>   }

Done.

[karlklose, 2015-04-13 12:38:54]

On 2015/04/13 12:35:55, asgerf wrote:
>
https://codereview.chromium.org/1087483003/diff/1/pkg/compiler/lib/src/cps_ir...
> File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):
> 
>
https://codereview.chromium.org/1087483003/diff/1/pkg/compiler/lib/src/cps_ir...
> pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:639: visitAssert(ast.Send
> node, ast.Node condition, _) {
> On 2015/04/13 12:31:51, karlklose wrote:
> > I would prefer to keep the type annotation and to structure the code like
> this:
> > 
> >   if (compiler.enableUserAssertions) {
> >     return giveup(node, 'assert in checked mode not implemented');
> >   } else {
> >     // The call to assert and its argument expression can be ignored
> >     // in production mode.
> >     return null;
> >   }
> 
> Done.

Still LGTM!

[asgerf, 2015-04-13 14:06:06]

Committed patchset #2 (id:20001) manually as 45103 (presubmit successful).