Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1087463005: Simplification in resolving classes (Closed)

Created:
5 years, 8 months ago by hausner
Modified:
5 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Simplification in resolving classes The helper functions in Parser to resolve classes in the library and prefix scope created an unnecessary handlescope. With libraries caching previous lookups, and with namespaces now using dictionaries, there are just a handful (so to speak) of handles allocated for the lookup. That does not warrant a handlescope. Removed the helper functions. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -34 lines) Patch
M runtime/vm/parser.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +6 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 8 months ago (2015-04-23 18:32:28 UTC) #2
siva
lgtm
5 years, 8 months ago (2015-04-23 23:48:25 UTC) #3
hausner
5 years, 8 months ago (2015-04-24 15:46:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45399 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698