Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1087303004: Add support for user-defined HTML files. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -42 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M README.md View 1 chunk +31 lines, -0 lines 0 comments Download
A lib/dart.js View 1 chunk +69 lines, -0 lines 0 comments Download
M lib/pub_serve.dart View 1 3 chunks +16 lines, -9 lines 0 comments Download
M lib/src/runner/browser/server.dart View 1 4 chunks +33 lines, -19 lines 0 comments Download
M pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
M test/runner/browser/runner_test.dart View 3 chunks +196 lines, -0 lines 0 comments Download
M test/runner/pub_serve_test.dart View 5 chunks +104 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 8 months ago (2015-04-17 19:45:55 UTC) #1
kevmoo
one nit, otherwise LGTM https://codereview.chromium.org/1087303004/diff/1/lib/pub_serve.dart File lib/pub_serve.dart (right): https://codereview.chromium.org/1087303004/diff/1/lib/pub_serve.dart#newcode5 lib/pub_serve.dart:5: import 'dart:convert'; Need dart:async
5 years, 8 months ago (2015-04-17 22:09:29 UTC) #2
nweiz
Code review changes
5 years, 8 months ago (2015-04-17 22:10:51 UTC) #3
nweiz
https://codereview.chromium.org/1087303004/diff/1/lib/pub_serve.dart File lib/pub_serve.dart (right): https://codereview.chromium.org/1087303004/diff/1/lib/pub_serve.dart#newcode5 lib/pub_serve.dart:5: import 'dart:convert'; On 2015/04/17 22:09:29, kevmoo wrote: > Need ...
5 years, 8 months ago (2015-04-17 22:10:59 UTC) #4
nweiz
5 years, 8 months ago (2015-04-17 22:11:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e87a37f833146f931216ea27cb1dbc773fd226e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698