Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Issue 1087243002: Remove an unused field from one of the CPS translation classes. (Closed)

Created:
5 years, 8 months ago by Kevin Millikin (Google)
Modified:
5 years, 8 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove an unused field from one of the CPS translation classes. BUG= R=asgerf@google.com Committed: https://code.google.com/p/dart/source/detail?r=45168

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 4 chunks +3 lines, -9 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Kevin Millikin (Google)
5 years, 8 months ago (2015-04-15 14:53:25 UTC) #2
asgerf
lgtm
5 years, 8 months ago (2015-04-15 15:01:36 UTC) #3
Kevin Millikin (Google)
Committed patchset #1 (id:1) manually as 45168 (presubmit successful).
5 years, 8 months ago (2015-04-15 15:13:27 UTC) #4
Kevin Millikin (Google)
https://codereview.chromium.org/1087243002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/1087243002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart#newcode479 pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:479: // TODO(johnniwinther): Make these field final and remove the ...
5 years, 8 months ago (2015-04-15 15:14:58 UTC) #5
Paul Berry
5 years, 8 months ago (2015-04-15 16:14:58 UTC) #6
Message was sent while issue was closed.
On 2015/04/15 15:14:58, kmillikin wrote:
>
https://codereview.chromium.org/1087243002/diff/1/pkg/compiler/lib/src/cps_ir...
> File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):
> 
>
https://codereview.chromium.org/1087243002/diff/1/pkg/compiler/lib/src/cps_ir...
> pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:479: // TODO(johnniwinther):
> Make these field final and remove the default values
> I guess this comment was referring to the field I just removed.  I'll ask
Johnni
> to be sure and remove the comment if so.

This CL is causing some analyzer tests to fail, e.g.: python tools/test.py
--checked -mrelease -cdart2analyzer -rnone -t240 pkg/docgen/test/typedef_test

The analyzer output is:
WARNING|STATIC_TYPE_WARNING|INVALID_ASSIGNMENT|/Users/paulberry/dart/dart-test/dart/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart|2300|41|104|A
value of type 'void' cannot be assigned to a variable of type 'List<Parameter>'

Looking at line 2300 of cps_ir_builder_task.dart, it looks like the return value
of buildFunctionHeader() is still needed.  Would you mind having a look?

Powered by Google App Engine
This is Rietveld 408576698