Issue 1086753006: Properly load Dartium from the Dart Editor when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1086753006: Properly load Dartium from the Dart Editor when possible. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Properly load Dartium from the Dart Editor when possible. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/2a6da419431b666e4570882bd25852a9458b3af9

Patch Set 2 : Code review changes #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	CHANGELOG.md	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	lib/src/runner/browser/dartium.dart	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

https://codereview.chromium.org/1086753006/diff/1/lib/src/runner/browser/dartium.dart File lib/src/runner/browser/dartium.dart (right): https://codereview.chromium.org/1086753006/diff/1/lib/src/runner/browser/dartium.dart#newcode109 lib/src/runner/browser/dartium.dart:109: dir, "chromium/Chromium.app/Contents/MacOs/Chromium"); MasO*S*

5 years, 8 months ago (2015-04-16 22:18:33 UTC) #2

nweiz

Committed patchset #2 (id:20001) manually as 2a6da419431b666e4570882bd25852a9458b3af9 (presubmit successful).

5 years, 8 months ago (2015-04-16 22:21:33 UTC) #4

nweiz

5 years, 8 months ago (2015-04-16 22:21:34 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1086753006/diff/1/lib/src/runner/browser/dart...
File lib/src/runner/browser/dartium.dart (right):

https://codereview.chromium.org/1086753006/diff/1/lib/src/runner/browser/dart...
lib/src/runner/browser/dartium.dart:109: dir,
"chromium/Chromium.app/Contents/MacOs/Chromium");
On 2015/04/16 22:18:33, kevmoo wrote:
> MasO*S*

Done.

Expand Messages | Collapse Messages

Issue 1086753006: Properly load Dartium from the Dart Editor when possible. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages