Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1086713002: Add Dart_NewIntegerFromUint64. (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add Dart_NewIntegerFromUint64. Fix Dart_IntegerToUint64 for negative Smis. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45143

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M runtime/include/dart_api.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 8 months ago (2015-04-13 17:45:45 UTC) #2
siva
lgtm https://codereview.chromium.org/1086713002/diff/20001/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://codereview.chromium.org/1086713002/diff/20001/runtime/include/dart_api.h#newcode1402 runtime/include/dart_api.h:1402: * \param value The value of the integer. ...
5 years, 8 months ago (2015-04-14 17:42:45 UTC) #3
rmacnak
https://codereview.chromium.org/1086713002/diff/20001/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://codereview.chromium.org/1086713002/diff/20001/runtime/include/dart_api.h#newcode1402 runtime/include/dart_api.h:1402: * \param value The value of the integer. On ...
5 years, 8 months ago (2015-04-14 17:51:46 UTC) #4
rmacnak
5 years, 8 months ago (2015-04-14 17:52:13 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 45143 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698