Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1086543002: Revert "Handle SendSet and NewExpression through NewResolvedVisitor." (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Handle SendSet and NewExpression through NewResolvedVisitor." This reverts commit r45091. BUG= Committed: https://code.google.com/p/dart/source/detail?r=45093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -114 lines) Patch
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 2 chunks +2 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 8 chunks +15 lines, -91 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
TBR
5 years, 8 months ago (2015-04-13 10:41:24 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 45093 (presubmit successful).
5 years, 8 months ago (2015-04-13 10:43:07 UTC) #3
karlklose
5 years, 8 months ago (2015-04-13 10:46:49 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698