Issue 1086323002: cps-ir: Remove redundant identical() calls in type propagation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1086323002: cps-ir: Remove redundant identical() calls in type propagation. (Closed)

Created:
5 years, 8 months ago by asgerf

Modified:
5 years, 7 months ago

Reviewers:
karlklose, Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

cps-ir: Remove redundant identical() calls in type propagation. Also, use the inferred type from dynamic method calls. Changed the file from a "part of" to a re-exported file so the imports are not polluting the other optimization passes. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=45488

Patch Set 1 #

Patch Set 2 : Add generic #

Patch Set 3 : containsOnlyBool -> isDefinitelyBool #

Patch Set 4 : Rebase + update tests #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -26 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/optimizers.dart	View	1 2 3	1 chunk	+4 lines, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	1 2 3	10 chunks	+64 lines, -6 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_closures_test.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart	View	1 2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

5 years, 7 months ago (2015-05-04 12:14:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 45488 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages