Issue 1086213002: Support a @Timeout annotation.

Issue 1086213002: Support a @Timeout annotation. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Support a @Timeout annotation. Closes #9 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/f45ac37d234a9e4474ff0ffb9c6ca106985abcf6

Patch Set 2 : Fix isolate_listener_test. #

Total comments: 2

Patch Set 3 : CHANGELOG + README #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+523 lines, -119 lines)			Patch
M	CHANGELOG.md	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	README.md	View	1 2	1 chunk	+43 lines, -0 lines	0 comments	Download
M	lib/pub_serve.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/src/backend/invoker.dart	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	lib/src/backend/metadata.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/runner/browser/browser_manager.dart	View		2 chunks	+9 lines, -6 lines	0 comments	Download
M	lib/src/runner/browser/iframe_listener.dart	View		2 chunks	+10 lines, -2 lines	0 comments	Download
M	lib/src/runner/browser/server.dart	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	lib/src/runner/loader.dart	View		3 chunks	+25 lines, -16 lines	0 comments	Download
M	lib/src/runner/parse_metadata.dart	View		2 chunks	+192 lines, -37 lines	0 comments	Download
M	lib/src/runner/vm/isolate_listener.dart	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	pubspec.yaml	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/runner/browser/runner_test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	test/runner/isolate_listener_test.dart	View	1	6 chunks	+12 lines, -12 lines	0 comments	Download
M	test/runner/parse_metadata_test.dart	View		3 chunks	+167 lines, -37 lines	0 comments	Download
M	test/runner/runner_test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/1086213002/diff/20001/lib/src/runner/browser/browser_manager.dart File lib/src/runner/browser/browser_manager.dart (right): https://codereview.chromium.org/1086213002/diff/20001/lib/src/runner/browser/browser_manager.dart#newcode50 lib/src/runner/browser/browser_manager.dart:50: "channel": suiteChannel.id, extra comma?

5 years, 8 months ago (2015-04-15 22:29:09 UTC) #2

nweiz

https://codereview.chromium.org/1086213002/diff/20001/lib/src/runner/browser/browser_manager.dart File lib/src/runner/browser/browser_manager.dart (right): https://codereview.chromium.org/1086213002/diff/20001/lib/src/runner/browser/browser_manager.dart#newcode50 lib/src/runner/browser/browser_manager.dart:50: "channel": suiteChannel.id, On 2015/04/15 22:29:08, kevmoo wrote: > extra ...

5 years, 8 months ago (2015-04-15 22:58:22 UTC) #3

nweiz

5 years, 8 months ago (2015-04-15 22:58:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
f45ac37d234a9e4474ff0ffb9c6ca106985abcf6 (presubmit successful).

Expand Messages | Collapse Messages