Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1085883003: Make IsolateWrapper compatible with the 1.11 isolate API changes. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make IsolateWrapper compatible with the 1.11 isolate API changes. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/ed266f5b483e1bcae68a3b893c29cd8928bcfad2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M lib/src/runner/loader.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/isolate_wrapper.dart View 3 chunks +7 lines, -5 lines 0 comments Download
M test/runner/isolate_listener_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 8 months ago (2015-04-14 21:00:23 UTC) #1
kevmoo
Validated on dev and bleeding_edge LGTM
5 years, 8 months ago (2015-04-14 21:06:41 UTC) #2
nweiz
5 years, 8 months ago (2015-04-14 21:24:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ed266f5b483e1bcae68a3b893c29cd8928bcfad2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698