Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1085803002: Add a --cps-ir flag to the testing script to allow us to run with the new cps based backend in dart… (Closed)

Created:
5 years, 8 months ago by ricow1
Modified:
5 years, 8 months ago
Reviewers:
karlklose, Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add a --cps-ir flag to the testing script to allow us to run with the new cps based backend in dart2js R=whesse@google.com, karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45136

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add cache #

Patch Set 3 : simplify #

Patch Set 4 : fix #

Patch Set 5 : more foobar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M tools/testing/dart/compiler_configuration.dart View 1 2 3 4 5 chunks +22 lines, -3 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ricow1
5 years, 8 months ago (2015-04-14 08:35:06 UTC) #1
karlklose
https://codereview.chromium.org/1085803002/diff/1/tools/testing/dart/compiler_configuration.dart File tools/testing/dart/compiler_configuration.dart (right): https://codereview.chromium.org/1085803002/diff/1/tools/testing/dart/compiler_configuration.dart#newcode262 tools/testing/dart/compiler_configuration.dart:262: env = {}..addAll(environmentOverrides)..addAll(vmoption); Shouldn't this be 'env.addAll(...)' to preserve ...
5 years, 8 months ago (2015-04-14 08:56:03 UTC) #2
ricow1
https://codereview.chromium.org/1085803002/diff/1/tools/testing/dart/compiler_configuration.dart File tools/testing/dart/compiler_configuration.dart (right): https://codereview.chromium.org/1085803002/diff/1/tools/testing/dart/compiler_configuration.dart#newcode262 tools/testing/dart/compiler_configuration.dart:262: env = {}..addAll(environmentOverrides)..addAll(vmoption); On 2015/04/14 08:56:03, karlklose wrote: > ...
5 years, 8 months ago (2015-04-14 08:59:10 UTC) #3
Bill Hesse
lgtm https://codereview.chromium.org/1085803002/diff/1/tools/testing/dart/compiler_configuration.dart File tools/testing/dart/compiler_configuration.dart (right): https://codereview.chromium.org/1085803002/diff/1/tools/testing/dart/compiler_configuration.dart#newcode261 tools/testing/dart/compiler_configuration.dart:261: var vmoption = { 'DART_VM_OPTIONS' : '-DUSE_CPS_IR=true' }; ...
5 years, 8 months ago (2015-04-14 11:42:33 UTC) #4
ricow1
added cache, ptal
5 years, 8 months ago (2015-04-14 11:58:26 UTC) #5
Bill Hesse
LGTM, if we add a check that environment_overrides is not null.
5 years, 8 months ago (2015-04-14 12:23:54 UTC) #6
ricow1
5 years, 8 months ago (2015-04-14 12:33:57 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 45136 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698