Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1085593003: Split `run_config` into `run_config download` and `run_config generate`. (Closed)

Created:
5 years, 8 months ago by kustermann
Modified:
5 years, 8 months ago
Reviewers:
wibling, Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/googleapis.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split `run_config` into `run_config download` and `run_config generate`. R=sgjesse@google.com, wibling@google.com Committed: https://github.com/dart-lang/googleapis/commit/b43eed663c572d7b7fcf606c309979c3c884b0ca

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -69 lines) Patch
M README.md View 1 chunk +10 lines, -1 line 0 comments Download
M bin/generate.dart View 1 2 chunks +17 lines, -1 line 0 comments Download
M lib/googleapis_generator.dart View 1 2 chunks +56 lines, -30 lines 0 comments Download
M lib/src/package_configuration.dart View 9 chunks +83 lines, -37 lines 0 comments Download
M pubspec.yaml View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kustermann
5 years, 8 months ago (2015-04-13 13:11:04 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/1085593003/diff/20001/lib/src/package_configuration.dart File lib/src/package_configuration.dart (right): https://codereview.chromium.org/1085593003/diff/20001/lib/src/package_configuration.dart#newcode96 lib/src/package_configuration.dart:96: List<RestDescription> allApis = await fetchDiscoveryDocuments(); Please update the ...
5 years, 8 months ago (2015-04-13 13:25:06 UTC) #3
wibling
lgtm Very nice:) This should make it much easier to roll. https://codereview.chromium.org/1085593003/diff/20001/lib/src/package_configuration.dart File lib/src/package_configuration.dart (right): ...
5 years, 8 months ago (2015-04-13 13:27:37 UTC) #4
kustermann
https://codereview.chromium.org/1085593003/diff/20001/lib/src/package_configuration.dart File lib/src/package_configuration.dart (right): https://codereview.chromium.org/1085593003/diff/20001/lib/src/package_configuration.dart#newcode96 lib/src/package_configuration.dart:96: List<RestDescription> allApis = await fetchDiscoveryDocuments(); On 2015/04/13 13:25:06, Søren ...
5 years, 8 months ago (2015-04-13 13:58:24 UTC) #5
kustermann
https://codereview.chromium.org/1085593003/diff/20001/lib/src/package_configuration.dart File lib/src/package_configuration.dart (right): https://codereview.chromium.org/1085593003/diff/20001/lib/src/package_configuration.dart#newcode96 lib/src/package_configuration.dart:96: List<RestDescription> allApis = await fetchDiscoveryDocuments(); On 2015/04/13 13:25:06, Søren ...
5 years, 8 months ago (2015-04-13 13:58:24 UTC) #6
kustermann
5 years, 8 months ago (2015-04-13 13:58:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b43eed663c572d7b7fcf606c309979c3c884b0ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698