Dummy receiver optimization

Dummy receiver optimization

When we replace an interceptor with the intercepted object (a 'self-interceptor')

  m = getInterceptor(a);
  m.method(a)
-->
  a.method(a)

we can replace the receiver with a dummy value:

-->
  a.method(0)

provided the method never accesses the explicit interceptor argument.  This condition is satisfied for methods that are not mixed into native classes.

We create a DummyReceiverConstant to ensure the dummy receiver argument has the correct type.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31250

[floitsch, 2013-12-18 19:20:11]

LGTM.

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:171: //
explicit receiver.  https://code.google.com/p/dart/issues/detail?id=8942
Update comment.

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart
(right):

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:218:
var users = node.usedBy.toList();
We use types.

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:224:
for (var user in users) {
ditto.

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:234:
var dummy = graph.addConstant(constant, compiler);
ditto.

[sra1, 2013-12-19 03:28:15]

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:171: //
explicit receiver.  https://code.google.com/p/dart/issues/detail?id=8942
On 2013/12/18 19:20:12, floitsch wrote:
> Update comment.

Done.

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart
(right):

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:218:
var users = node.usedBy.toList();
On 2013/12/18 19:20:12, floitsch wrote:
> We use types.

Done.

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:224:
for (var user in users) {
On 2013/12/18 19:20:12, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/108553006/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:234:
var dummy = graph.addConstant(constant, compiler);
On 2013/12/18 19:20:12, floitsch wrote:
> ditto.

Done.

[sra1, 2013-12-19 03:55:34]

Committed patchset #4 manually as r31250 (presubmit successful).