Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 108533005: Fixes Unimplemented crasher on MIPS. (Closed)

Created:
7 years ago by zra
Modified:
7 years ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M runtime/vm/signal_handler_linux.cc View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
If code will crash on ARM or MIPS, please enable it only under a flag. ...
7 years ago (2013-12-17 17:28:47 UTC) #1
Cutch
lgtm. The only other place that will have an UNIMPLEMENTED is in signal_handler_android.cc. That should ...
7 years ago (2013-12-17 17:33:16 UTC) #2
zra
Committed patchset #1 manually as r31197 (presubmit successful).
7 years ago (2013-12-17 17:34:12 UTC) #3
siva
7 years ago (2013-12-17 18:01:53 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698